Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/12093 )
Change subject: Log: add stdout target ...................................................................... Patch Set 1: (3 comments) https://gerrit.osmocom.org/#/c/12093/1/src/logging.c File src/logging.c: https://gerrit.osmocom.org/#/c/12093/1/src/logging.c@813 PS1, Line 813: static struct log_target *_log_target_create_std(FILE *out, enum log_target_type lt) _log_target_create_fp would be more descriptive. https://gerrit.osmocom.org/#/c/12093/1/src/logging.c@926 PS1, Line 926: if (target->tgt_file.out != stdout) This looks wrong or at least really messy. https://gerrit.osmocom.org/#/c/12093/1/src/vty/logging_vty.c File src/vty/logging_vty.c: https://gerrit.osmocom.org/#/c/12093/1/src/vty/logging_vty.c@881 PS1, Line 881: /* we don't support vty logging to stdout to avoid messing up vty prompt and user input */ I don't get what's the issue here. -- To view, visit https://gerrit.osmocom.org/12093 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia786361f5f687e43b27d87a45b4630bca58bcfe8 Gerrit-Change-Number: 12093 Gerrit-PatchSet: 1 Gerrit-Owner: Max <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-CC: Pau Espin Pedrol <[email protected]> Gerrit-Comment-Date: Tue, 04 Dec 2018 11:58:51 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
