Stefan Sperling has posted comments on this change. (
https://gerrit.osmocom.org/12095 )
Change subject: Logging: don't print hex category by default
......................................................................
Patch Set 3:
Note that log_target_create() still contains this code:
/* global settings */
target->use_color = 1;
target->print_timestamp = 0;
target->print_filename2 = LOG_FILENAME_PATH;
target->print_category_hex = true;
Wouldn't it be easier to change this hard-coded default to 'false' here?
--
To view, visit https://gerrit.osmocom.org/12095
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6dc3898958cf60147ad73c52cf0b3990bd26359e
Gerrit-Change-Number: 12095
Gerrit-PatchSet: 3
Gerrit-Owner: Max <[email protected]>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Max <[email protected]>
Gerrit-Reviewer: Neels Hofmeyr <[email protected]>
Gerrit-Reviewer: Pau Espin Pedrol <[email protected]>
Gerrit-CC: Stefan Sperling <[email protected]>
Gerrit-Comment-Date: Tue, 04 Dec 2018 13:47:38 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
