Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11957 )
Change subject: bsc: Fix lchan iteration for dyn TS during PDCH Deact ...................................................................... Patch Set 4: Code-Review+2 (1 comment) the amount of meta overhead compared to this fix is amazing :) https://gerrit.osmocom.org/#/c/11957/4//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/#/c/11957/4//COMMIT_MSG@8 PS4, Line 8: ok, will accept this time, but still: a commit log should first and foremost briefly say what is being done and also why in a way that is quick to read and understand. Imagine someone trying to find a bug and reading all the commit logs. Reading this would be "yes, but what was wrong with the iteration?" which is only revealed three paragraphs later... Add more details in the bottom if you must, but first punch out a crisp TLDR. -- To view, visit https://gerrit.osmocom.org/11957 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9cedb77d6578597f1febab36c54b2ee427c7a4a2 Gerrit-Change-Number: 11957 Gerrit-PatchSet: 4 Gerrit-Owner: Pau Espin Pedrol <[email protected]> Gerrit-Assignee: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-Comment-Date: Tue, 04 Dec 2018 16:48:40 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
