Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/6239 )

Change subject: vty: add commands to show TBF of a certain kind
......................................................................


Patch Set 4: Code-Review-1

(1 comment)

https://gerrit.osmocom.org/#/c/6239/4/src/pcu_vty_functions.cpp
File src/pcu_vty_functions.cpp:

https://gerrit.osmocom.org/#/c/6239/4/src/pcu_vty_functions.cpp@46
PS4, Line 46: static void tbf_print_vty_info(struct vty *vty, gprs_rlcmac_tbf 
*tbf, bool show_ccch, bool show_pacch)
looks like these parameters added in this commit are not used in this function.



--
To view, visit https://gerrit.osmocom.org/6239
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I80f8df4fe663a0346f4289a4220b761e39726312
Gerrit-Change-Number: 6239
Gerrit-PatchSet: 4
Gerrit-Owner: Max <[email protected]>
Gerrit-Reviewer: Harald Welte <[email protected]>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Max <[email protected]>
Gerrit-Reviewer: Pau Espin Pedrol <[email protected]>
Gerrit-Comment-Date: Wed, 05 Dec 2018 10:36:39 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes

Reply via email to