Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/12126 )
Change subject: make: prepare for adding transcript tests ...................................................................... Patch Set 1: Code-Review-1 (2 comments) https://gerrit.osmocom.org/#/c/12126/1/tests/Makefile.am File tests/Makefile.am: https://gerrit.osmocom.org/#/c/12126/1/tests/Makefile.am@73 PS1, Line 73: if [ -z "$(PYTHON)" ]; then echo "ERROR: python not configured, for manual invocation use 'make PYTHON=/usr/bin/python'"; exit 1; fi More simple, since already contains a shebang (#!/usr/bin/env python2), let's drop the PYTHON thing completely and use ./ instead: $(srcdir)/ctrl_test_runner.py -w $(abs_top_builddir) -v I actually did that in some project already because configure PYTHON definition through some automake macro is broken / not working in all cases. https://gerrit.osmocom.org/#/c/12126/1/tests/Makefile.am@84 PS1, Line 84: $(MAKE) ctrl-python-test Cannot this be specified like this? ctrl-test: ctrl-python-test ctrl-transcript-test -- To view, visit https://gerrit.osmocom.org/12126 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I688657e56ae469c07b9f25ba37275d38dbd457e2 Gerrit-Change-Number: 12126 Gerrit-PatchSet: 1 Gerrit-Owner: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-Comment-Date: Wed, 05 Dec 2018 10:46:52 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
