Max has posted comments on this change. ( https://gerrit.osmocom.org/12147 )
Change subject: ctrl2cgi: log request time ...................................................................... Patch Set 1: > So maybe add a log statement here with the difference between ts and > datetime.now and pass a new datetime.now into the callback? Good point, although I'm not sure how lazy python in this case: if arguments to sem.run() are evaluated in advance that would work but if it's deferred until it's acquired than both ts would fire at the same time. I'll try to test and see if this can be implemented in a separate patch. -- To view, visit https://gerrit.osmocom.org/12147 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: python/osmo-python-tests Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I11c8ac67a2730a9c6912694e5b83bbdf08fe357d Gerrit-Change-Number: 12147 Gerrit-PatchSet: 1 Gerrit-Owner: Max <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <[email protected]> Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-Reviewer: daniel <[email protected]> Gerrit-Comment-Date: Thu, 06 Dec 2018 10:00:15 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No
