Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/12158 )
Change subject: gsm48_mi_to_string(): style tweak: break on error first ...................................................................... Patch Set 1: > IMO that break inside the if is confusing, I prefer the old way. what? but that's the usual way we branch off for errors. Well ok then, let's abandon this then. no use discussing nothing -- To view, visit https://gerrit.osmocom.org/12158 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic76bc5e84ad1278fa3b2db5f5e28cadf1d90a343 Gerrit-Change-Number: 12158 Gerrit-PatchSet: 1 Gerrit-Owner: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-CC: Pau Espin Pedrol <[email protected]> Gerrit-Comment-Date: Thu, 06 Dec 2018 17:05:29 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No
