Pau Espin Pedrol has posted comments on this change. (
https://gerrit.osmocom.org/12125 )
Change subject: lms: Move {under,over}run checks into separate method
......................................................................
Patch Set 2:
(2 comments)
https://gerrit.osmocom.org/#/c/12125/2/Transceiver52M/device/lms/LMSDevice.cpp
File Transceiver52M/device/lms/LMSDevice.cpp:
https://gerrit.osmocom.org/#/c/12125/2/Transceiver52M/device/lms/LMSDevice.cpp@538
PS2, Line 538: update_stream_stats(i, underrun, overrun);
> the under/overrun stuff now moved to above rc != len check, are your sure
> that is correct?
Yes, that's fine too, but needs proper explanation, I'll add it to next commit.
https://gerrit.osmocom.org/#/c/12125/2/Transceiver52M/device/lms/LMSDevice.cpp@544
PS2, Line 544: //if (timestamp != (TIMESTAMP)rx_metadata.timestamp)
> ?
My bad, some local state sneaked in.
--
To view, visit https://gerrit.osmocom.org/12125
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7f450aa79f6285d14826c40ecfdd9490d00509ef
Gerrit-Change-Number: 12125
Gerrit-PatchSet: 2
Gerrit-Owner: Pau Espin Pedrol <pes...@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pes...@sysmocom.de>
Gerrit-Comment-Date: Fri, 07 Dec 2018 10:10:05 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
