Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/12181 )
Change subject: trx_toolkit/burst_fwd.py: document and refactor BurstForwarder ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/12181/1/src/target/trx_toolkit/burst_fwd.py File src/target/trx_toolkit/burst_fwd.py: https://gerrit.osmocom.org/#/c/12181/1/src/target/trx_toolkit/burst_fwd.py@108 PS1, Line 108: # Randomization of RSSI > May be worth explaining why those below are not moved inside reset_dl and > reset_ul. The motivation for this change was introducing RESET CTRL command. Since those flags below are set from the command line, they should not be reseted from the control interface. Moreover, they are going to be removed in the following changes. Let's just merge it. -- To view, visit https://gerrit.osmocom.org/12181 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6b1bf41cf22f01a7e7ecc91c625fb0d2bf4bfeac Gerrit-Change-Number: 12181 Gerrit-PatchSet: 1 Gerrit-Owner: Vadim Yanitskiy <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-Reviewer: Vadim Yanitskiy <[email protected]> Gerrit-Comment-Date: Fri, 07 Dec 2018 12:32:09 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
