Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12202 )
Change subject: display last location update timestamp in vty ...................................................................... Patch Set 2: (3 comments) https://gerrit.osmocom.org/#/c/12202/1/src/db_hlr.c File src/db_hlr.c: https://gerrit.osmocom.org/#/c/12202/1/src/db_hlr.c@430 PS1, Line 430: if (last_lu_seen_str && last_lu_seen_str[0] != '\0') { > Move it to the start of the function. Done in next patch set. https://gerrit.osmocom.org/#/c/12202/1/src/hlr_vty_subscr.c File src/hlr_vty_subscr.c: https://gerrit.osmocom.org/#/c/12202/1/src/hlr_vty_subscr.c@39 PS1, Line 39: get_datestr(const time_t *t, char *datebuf) > 'const time_t *' to clearly indicate it's an input? Yes, it is better with const. Thanks. https://gerrit.osmocom.org/#/c/12202/1/src/hlr_vty_subscr.c@44 PS1, Line 44: p = strchr(s, '\n'); > Reading in the man page that it adds \n at the end -> lol Yes the ctime_r interface is quite odd. -- To view, visit https://gerrit.osmocom.org/12202 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie180c434f02ffec0d4b2f651a73258a8126b2e1a Gerrit-Change-Number: 12202 Gerrit-PatchSet: 2 Gerrit-Owner: Stefan Sperling <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-Reviewer: Stefan Sperling <[email protected]> Gerrit-CC: Harald Welte <[email protected]> Gerrit-Comment-Date: Mon, 10 Dec 2018 13:18:53 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
