Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/12223 )
Change subject: Add sgsn_acl_count() ...................................................................... Patch Set 2: Code-Review-1 (1 comment) https://gerrit.osmocom.org/#/c/12223/2/src/gprs/sgsn_auth.c File src/gprs/sgsn_auth.c: https://gerrit.osmocom.org/#/c/12223/2/src/gprs/sgsn_auth.c@56 PS2, Line 56: size_t sgsn_acl_count(const struct sgsn_config *cfg) Do we really need this kind of one line functions? Furthermore, it's not in any header file, and it's not static. -- To view, visit https://gerrit.osmocom.org/12223 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia7c5b36d07672ea43bfa2b531b9b6c56ba65161d Gerrit-Change-Number: 12223 Gerrit-PatchSet: 2 Gerrit-Owner: Max <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-Comment-Date: Mon, 10 Dec 2018 15:56:49 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
