Max has posted comments on this change. ( https://gerrit.osmocom.org/12227 )
Change subject: ACL: integrate sanitize check into sgsn_acl_* functions ...................................................................... Patch Set 3: (2 comments) https://gerrit.osmocom.org/#/c/12227/2/src/gprs/sgsn_auth.c File src/gprs/sgsn_auth.c: https://gerrit.osmocom.org/#/c/12227/2/src/gprs/sgsn_auth.c@89 PS2, Line 89: return -ENOMEM; > based on where the information come from The sgsn_acl_add() and _del() are only called by vty code so where it comes from is always the same. > Is there any good reason to do it here? Yes - see commit description. https://gerrit.osmocom.org/#/c/12227/2/src/gprs/sgsn_vty.c File src/gprs/sgsn_vty.c: https://gerrit.osmocom.org/#/c/12227/2/src/gprs/sgsn_vty.c@a650 PS2, Line 650: > See my comment, I think osmo_imsi_sanitize() should be used here. In which library it's defined? -- To view, visit https://gerrit.osmocom.org/12227 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic3dff108148683b107e9edac430a0475283580e9 Gerrit-Change-Number: 12227 Gerrit-PatchSet: 3 Gerrit-Owner: Max <msur...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <msur...@sysmocom.de> Gerrit-Reviewer: Pau Espin Pedrol <pes...@sysmocom.de> Gerrit-Comment-Date: Mon, 10 Dec 2018 17:27:45 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No