Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12228 )
Change subject: disable recording of LU timestamps by default ...................................................................... Patch Set 3: (1 comment) https://gerrit.osmocom.org/#/c/12228/3/src/db_hlr.c File src/db_hlr.c: https://gerrit.osmocom.org/#/c/12228/3/src/db_hlr.c@688 PS3, Line 688: db_remove_reset(stmt); > This looks weird. […] Yes it looks weird, but it is correct. Is it OK to run other statements before the most recently used statement has been reset? If so we could simplify this code. Otherwise, moving some code into a function has the downside that the 'goto out:' doesn't work anymore for the code which was moved to the function. -- To view, visit https://gerrit.osmocom.org/12228 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2f18b5ddc9b4b8e1174c6dea71cddf1c8d2230df Gerrit-Change-Number: 12228 Gerrit-PatchSet: 3 Gerrit-Owner: Stefan Sperling <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-Reviewer: Stefan Sperling <[email protected]> Gerrit-Comment-Date: Mon, 10 Dec 2018 17:42:22 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
