Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12133 )
Change subject: Add VTY option to avoid sending empty Full BCCH Info for disabled SI ...................................................................... Patch Set 2: Code-Review+1 (4 comments) https://gerrit.osmocom.org/#/c/12133/2/src/osmo-bsc/bsc_init.c File src/osmo-bsc/bsc_init.c: https://gerrit.osmocom.org/#/c/12133/2/src/osmo-bsc/bsc_init.c@184 PS2, Line 184: rc = 0; /* some nanoBTs fw don't like receiving empty unsupported SI */ BTs -> BTS ? https://gerrit.osmocom.org/#/c/12133/2/src/osmo-bsc/bsc_vty.c File src/osmo-bsc/bsc_vty.c: https://gerrit.osmocom.org/#/c/12133/2/src/osmo-bsc/bsc_vty.c@3096 PS2, Line 3096: "Some nanoBTS fw versions are known to fail upron receival of these messages.\n") typo: upron -> upon https://gerrit.osmocom.org/#/c/12133/2/src/osmo-bsc/bsc_vty.c@3109 PS2, Line 3109: "Some nanoBTS fw versions are known to fail upron receival of these messages.\n") Same typo https://gerrit.osmocom.org/#/c/12133/1/src/osmo-bsc/gsm_data.c File src/osmo-bsc/gsm_data.c: https://gerrit.osmocom.org/#/c/12133/1/src/osmo-bsc/gsm_data.c@858 PS1, Line 858: bts->si_unused_send_empty = true; > Hm perhaps si_unused_send_empty? Yeah, si_unused_send_empy seems fine. -- To view, visit https://gerrit.osmocom.org/12133 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idec1daabc21de4eea5c55edd1dbb0e0775720fc7 Gerrit-Change-Number: 12133 Gerrit-PatchSet: 2 Gerrit-Owner: Pau Espin Pedrol <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-Reviewer: Stefan Sperling <[email protected]> Gerrit-Reviewer: Vadim Yanitskiy <[email protected]> Gerrit-Comment-Date: Mon, 10 Dec 2018 18:53:41 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
