Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12201 )
Change subject: move ASS-COMPL MGCP handling out of a_iface_bssap.c ...................................................................... Patch Set 3: Code-Review+1 (1 comment) https://gerrit.osmocom.org/#/c/12201/3/include/osmocom/msc/msc_mgcp.h File include/osmocom/msc/msc_mgcp.h: https://gerrit.osmocom.org/#/c/12201/3/include/osmocom/msc/msc_mgcp.h@27 PS3, Line 27: struct gsm0808_speech_codec; > Why not adding correct headers instead? Yes, seems like osmocom/msc/ran_conn.h and osmocom/gsm/protocol/gsm_08_08.h would do? -- To view, visit https://gerrit.osmocom.org/12201 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8137215c443239bddf3e69b5715839a365b73b6c Gerrit-Change-Number: 12201 Gerrit-PatchSet: 3 Gerrit-Owner: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Pau Espin Pedrol <pes...@sysmocom.de> Gerrit-Reviewer: Stefan Sperling <s...@stsp.name> Gerrit-Comment-Date: Mon, 10 Dec 2018 19:03:59 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
