Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12227 )
Change subject: ACL: integrate sanitize check into sgsn_acl_* functions ...................................................................... Patch Set 3: (1 comment) https://gerrit.osmocom.org/#/c/12227/3/src/gprs/sgsn_auth.c File src/gprs/sgsn_auth.c: https://gerrit.osmocom.org/#/c/12227/3/src/gprs/sgsn_auth.c@58 PS3, Line 58: return true; The docstring says the imsi is truncated if we return true from this function. "truncated" implies that dst contains all imsi data up to MAX_DIGITS, and any remaining imsi data beyond MAX_DIGITS will be missing from dst. But in fact, when we return true here, the destination buffer is still empty - it does not contain any imsi data! So this is a contradiciton. I cannot actully tell what this code intends to do. It looks to me like either the docstring or the code should be fixed. -- To view, visit https://gerrit.osmocom.org/12227 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic3dff108148683b107e9edac430a0475283580e9 Gerrit-Change-Number: 12227 Gerrit-PatchSet: 3 Gerrit-Owner: Max <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <[email protected]> Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-CC: Stefan Sperling <[email protected]> Gerrit-Comment-Date: Mon, 10 Dec 2018 19:35:50 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
