Neels Hofmeyr has posted comments on this change. ( 
https://gerrit.osmocom.org/12123 )

Change subject: utils: add EF [H|O]PLMNwAcT decoding.
......................................................................


Patch Set 1:

(1 comment)

in the test output on jenkins, I see

  PLMNwAcT: ffffffffff # unused
  ffffffffff # unused
  ffffffffff # unused
  ffffffffff # unused

maybe if multiple lines are involved, rather go for

  PLMNwAcT: ffffffffff # unused
            ffffffffff # unused
            ffffffffff # unused

or

  PLMNwAcT:
      ffffffffff # unused
      ffffffffff # unused
      ffffffffff # unused

?

https://gerrit.osmocom.org/#/c/12123/1/pySim/utils_test.py
File pySim/utils_test.py:

https://gerrit.osmocom.org/#/c/12123/1/pySim/utils_test.py@4
PS1, Line 4: import utils
(whitespace)



--
To view, visit https://gerrit.osmocom.org/12123
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9b8ca6ffd98f665690b84239d9a228e2c72c6ff9
Gerrit-Change-Number: 12123
Gerrit-PatchSet: 1
Gerrit-Owner: lazlo <dlsit...@gmail.com>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: dexter <pma...@sysmocom.de>
Gerrit-CC: Neels Hofmeyr <nhofm...@sysmocom.de>
Gerrit-Comment-Date: Tue, 11 Dec 2018 12:00:24 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Reply via email to