Neels Hofmeyr has posted comments on this change. ( 
https://gerrit.osmocom.org/10905 )

Change subject: LCLS: fix codec mismatch detection
......................................................................


Patch Set 4:

(1 comment)

(posting forgotten Draft comments, may be hoplessly outdated now. Easiest to 
get rid of them is to just "Reply", so bear with me, thx)

https://gerrit.osmocom.org/#/c/10905/1//COMMIT_MSG
Commit Message:

https://gerrit.osmocom.org/#/c/10905/1//COMMIT_MSG@13
PS1, Line 13: 00
> why are we abandoning struct members without […]
I edited the commit log to explain -- I forgot to remove them properly during 
refactoring.



--
To view, visit https://gerrit.osmocom.org/10905
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd7117092b1f170d5029303ae5ba0a49e02a8bfb
Gerrit-Change-Number: 10905
Gerrit-PatchSet: 4
Gerrit-Owner: dexter <pma...@sysmocom.de>
Gerrit-Assignee: Neels Hofmeyr <nhofm...@sysmocom.de>
Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Vadim Yanitskiy <axilira...@gmail.com>
Gerrit-CC: Neels Hofmeyr <nhofm...@sysmocom.de>
Gerrit-Comment-Date: Tue, 11 Dec 2018 12:07:54 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Reply via email to