Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/2780 )
Change subject: ofono_client: Fix race condition when checking for required features ...................................................................... Patch Set 3: (1 comment) (posting forgotten Draft comments, may be hoplessly outdated now. Easiest to get rid of them is to just "Reply", so bear with me, thx) https://gerrit.osmocom.org/#/c/2780/3/src/osmo_gsm_tester/ofono_client.py File src/osmo_gsm_tester/ofono_client.py: https://gerrit.osmocom.org/#/c/2780/3/src/osmo_gsm_tester/ofono_client.py@234 PS3, Line 234: def property_list_contains(self, name, val, iface=I_MODEM): it is not clear that 'val' is a list/tuple of values ... I see no benefit in generalizing this into a separate function, will we ever re-use it elsewhere? -- To view, visit https://gerrit.osmocom.org/2780 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibbfbbd2be6ecd3cebae83becf1cc34e15dc8e579 Gerrit-Change-Number: 2780 Gerrit-PatchSet: 3 Gerrit-Owner: Pau Espin Pedrol <pes...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-CC: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-Comment-Date: Tue, 11 Dec 2018 12:10:23 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
