Max has posted comments on this change. ( https://gerrit.osmocom.org/12242 )
Change subject: remove pointless declaration of struct gsm_network ...................................................................... Patch Set 1: Code-Review-1 (1 comment) https://gerrit.osmocom.org/#/c/12242/1/src/gprs/sgsn_ctrl.c File src/gprs/sgsn_ctrl.c: https://gerrit.osmocom.org/#/c/12242/1/src/gprs/sgsn_ctrl.c@64 PS1, Line 64: struct ctrl_handle *sgsn_controlif_setup(void *data, const char *bind_addr, uint16_t port) I think it's even more confusing this way. If parameter is unused than simply drop the parameter. -- To view, visit https://gerrit.osmocom.org/12242 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib4151afa5bff01e63b462cca517fb60ac0503759 Gerrit-Change-Number: 12242 Gerrit-PatchSet: 1 Gerrit-Owner: Stefan Sperling <s...@stsp.name> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <msur...@sysmocom.de> Gerrit-Reviewer: Stefan Sperling <s...@stsp.name> Gerrit-Comment-Date: Tue, 11 Dec 2018 15:32:59 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
