Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/12259 )
Change subject: trx_toolkit/ctrl_if_*.py: transparently pass UDPLink arguments ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/12259/1/src/target/trx_toolkit/ctrl_if_bb.py File src/target/trx_toolkit/ctrl_if_bb.py: https://gerrit.osmocom.org/#/c/12259/1/src/target/trx_toolkit/ctrl_if_bb.py@37 PS1, Line 37: def __init__(self, *udp_link_args): what about calling it superclass_args or ctrliface_args? -- To view, visit https://gerrit.osmocom.org/12259 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia312a5e15ce88d5f7e8d76c4ea8c93c59d91be5a Gerrit-Change-Number: 12259 Gerrit-PatchSet: 1 Gerrit-Owner: Vadim Yanitskiy <axilira...@gmail.com> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-CC: Pau Espin Pedrol <pes...@sysmocom.de> Gerrit-Comment-Date: Tue, 11 Dec 2018 18:14:26 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
