Stefan Sperling has posted comments on this change. ( 
https://gerrit.osmocom.org/12302 )

Change subject: msc_vty.c: configurable retrieval of IMEI, IMEISV
......................................................................


Patch Set 1:

> Patch Set 1:
>
> (osmotestvty.py runs through locally for me)

With --enable-external-tests, 'make check' fails locally for me with your patch 
applied.

I suspect the reason is this:

Documentation error (missing docs):
<command id='retrieve-imeisv-early (0|1)'>
        <param name='retrieve-imeisv-early' doc='(null)' />
        <param name='0' doc='(null)' />
        <param name='1' doc='(null)' />
                                              
Documentation error (missing docs):
<command id='retrieve-imeisv-ciphered (0|1)'>
        <param name='retrieve-imeisv-ciphered' doc='(null)' />
        <param name='0' doc='(null)' />
        <param name='1' doc='(null)' />


--
To view, visit https://gerrit.osmocom.org/12302
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iee516b9cd7877b21207ce9a6d954109f19558163
Gerrit-Change-Number: 12302
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <[email protected]>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: osmith <[email protected]>
Gerrit-CC: Stefan Sperling <[email protected]>
Gerrit-Comment-Date: Fri, 14 Dec 2018 12:09:58 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No

Reply via email to