Max has posted comments on this change. ( https://gerrit.osmocom.org/11989 )
Change subject: gsupclient: add osmo_gsup_msg_enc_send() ...................................................................... Patch Set 3: Code-Review-1 (2 comments) Please double check. https://gerrit.osmocom.org/#/c/11989/3/src/gsupclient/gsup_client.c File src/gsupclient/gsup_client.c: https://gerrit.osmocom.org/#/c/11989/3/src/gsupclient/gsup_client.c@369 PS3, Line 369: struct osmo_gsup_message *gsup_msg) Why this isn't const? What modifies it? https://gerrit.osmocom.org/#/c/11989/3/src/gsupclient/gsup_client.c@380 PS3, Line 380: rc = osmo_gsup_encode(gsup_msgb, gsup_msg); gsup_msg is const in here according to osmo_gsup_encode() type signature. -- To view, visit https://gerrit.osmocom.org/11989 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0589ff27933e9bca2bcf93b8259004935778db8f Gerrit-Change-Number: 11989 Gerrit-PatchSet: 3 Gerrit-Owner: Vadim Yanitskiy <axilira...@gmail.com> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <msur...@sysmocom.de> Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-Reviewer: Stefan Sperling <s...@stsp.name> Gerrit-Comment-Date: Fri, 14 Dec 2018 12:51:12 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
