Max has posted comments on this change. ( https://gerrit.osmocom.org/11746 )
Change subject: Store subscriber's cell identity ...................................................................... Patch Set 3: (1 comment) This change is ready for review. https://gerrit.osmocom.org/#/c/11746/2/src/libmsc/a_iface_bssap.c File src/libmsc/a_iface_bssap.c: https://gerrit.osmocom.org/#/c/11746/2/src/libmsc/a_iface_bssap.c@51 PS2, Line 51: struct osmo_sccp_user *scu, int conn_id) > TBH, this looks ugly. I am not a big fun of such fancy […] How this makes it worse? The line I've added is properly aligned. Feel free to submit patch which aligns the rest of them right. -- To view, visit https://gerrit.osmocom.org/11746 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8544c30ea800ce8356a227b03a8b21bf3252be7e Gerrit-Change-Number: 11746 Gerrit-PatchSet: 3 Gerrit-Owner: Max <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <[email protected]> Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Vadim Yanitskiy <[email protected]> Gerrit-CC: Harald Welte <[email protected]> Gerrit-Comment-Date: Mon, 17 Dec 2018 09:39:50 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
