Neels Hofmeyr has posted comments on this change. ( 
https://gerrit.osmocom.org/11837 )

Change subject: chapters/gsup.adoc: document READY-FOR-SM message
......................................................................


Patch Set 7: Code-Review+1

(1 comment)

minor...

https://gerrit.osmocom.org/#/c/11837/7/common/chapters/gsup.adoc
File common/chapters/gsup.adoc:

https://gerrit.osmocom.org/#/c/11837/7/common/chapters/gsup.adoc@1239
PS7, Line 1239: |0x00|Reserved (used inside libosmocore only)
keep implementation details out of the spec. Reserved values should make sense 
from the procotol perspective.
Maybe I was wrong to plant the "reserved" concept in your mind, my apologies.



--
To view, visit https://gerrit.osmocom.org/11837
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I549b6c8840a1e86caac09e77fb8bc5042d939e62
Gerrit-Change-Number: 11837
Gerrit-PatchSet: 7
Gerrit-Owner: Vadim Yanitskiy <[email protected]>
Gerrit-Reviewer: Harald Welte <[email protected]>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <[email protected]>
Gerrit-Reviewer: Stefan Sperling <[email protected]>
Gerrit-Reviewer: Vadim Yanitskiy <[email protected]>
Gerrit-Comment-Date: Mon, 17 Dec 2018 14:55:40 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes

Reply via email to