Neels Hofmeyr has posted comments on this change. ( 
https://gerrit.osmocom.org/12332 )

Change subject: add MSC test for an invalid CIPHER MODE COMPLETE command
......................................................................


Patch Set 2: Code-Review+1

If the chosen cipher is not part of the offered ciphers, that should result in 
a LU reject, yes.

But possibly, what you have tested is that A5/2 is generally deprecated and 
should always be rejected?

Please clarify this with another test run and then submit.


--
To view, visit https://gerrit.osmocom.org/12332
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4492eb7d77371aaa047abae81a2dcf26fe46eb6a
Gerrit-Change-Number: 12332
Gerrit-PatchSet: 2
Gerrit-Owner: Stefan Sperling <[email protected]>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <[email protected]>
Gerrit-Reviewer: Stefan Sperling <[email protected]>
Gerrit-Comment-Date: Mon, 17 Dec 2018 19:32:06 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Reply via email to