Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/12341 )
Change subject: trx_toolkit/data_msg.py: use struct API for fn and toa256 coding ...................................................................... Patch Set 1: Code-Review+1 (1 comment) https://gerrit.osmocom.org/#/c/12341/1/src/target/trx_toolkit/data_msg.py File src/target/trx_toolkit/data_msg.py: https://gerrit.osmocom.org/#/c/12341/1/src/target/trx_toolkit/data_msg.py@372 PS1, Line 372: # Big endian, 2 bytes (int32_t) If it's 2 bytes, why does it say int32_t (4 bytes) here? -- To view, visit https://gerrit.osmocom.org/12341 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I10d2e15ac57a0524e9bc1c80ed6a0f6f5a263436 Gerrit-Change-Number: 12341 Gerrit-PatchSet: 1 Gerrit-Owner: Vadim Yanitskiy <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-Comment-Date: Tue, 18 Dec 2018 10:56:49 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
