Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/12339 )
Change subject: sysmobts_mgr: Prepare code for gpsd < 2.96 support ...................................................................... Patch Set 1: Code-Review-1 (1 comment) https://gerrit.osmocom.org/#/c/12339/1/src/osmo-bts-sysmo/misc/sysmobts_mgr_calib.c File src/osmo-bts-sysmo/misc/sysmobts_mgr_calib.c: https://gerrit.osmocom.org/#/c/12339/1/src/osmo-bts-sysmo/misc/sysmobts_mgr_calib.c@145 PS1, Line 145: here should be gpsdata = &gpsdata_buf or this would be a segfault, right? -- To view, visit https://gerrit.osmocom.org/12339 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaeb5ac527cc3e58168027021d0f60afa93d1fb6f Gerrit-Change-Number: 12339 Gerrit-PatchSet: 1 Gerrit-Owner: Pau Espin Pedrol <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Comment-Date: Tue, 18 Dec 2018 13:52:12 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
