Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/11069 )
Change subject: GSUP/SMS: introduce MO-/MT-FORWARD-SM messages ...................................................................... Patch Set 11: (3 comments) https://gerrit.osmocom.org/#/c/11069/11/src/gsm/gsup.c File src/gsm/gsup.c: https://gerrit.osmocom.org/#/c/11069/11/src/gsm/gsup.c@668 PS11, Line 668: sizeof(u8), gsup_msg->sm_rp_mr); > Use sizeof(*gsup_msg->sm_rp_mr) here? Done https://gerrit.osmocom.org/#/c/11069/11/src/gsm/gsup.c@694 PS11, Line 694: sizeof(u8), gsup_msg->sm_rp_mms); > Use sizeof(*gsup_msg->sm_rp_mms)? Done https://gerrit.osmocom.org/#/c/11069/11/src/gsm/gsup.c@699 PS11, Line 699: sizeof(u8), gsup_msg->sm_rp_cause); > Use sizeof(*gsup_msg->sm_rp_cause)? Done -- To view, visit https://gerrit.osmocom.org/11069 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibe325c64ae2d6c626b232533bb4cbc65fc2b5d71 Gerrit-Change-Number: 11069 Gerrit-PatchSet: 11 Gerrit-Owner: Vadim Yanitskiy <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Stefan Sperling <[email protected]> Gerrit-Reviewer: Vadim Yanitskiy <[email protected]> Gerrit-Comment-Date: Tue, 18 Dec 2018 14:53:40 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
