dexter has posted comments on this change. ( https://gerrit.osmocom.org/11488 )
Change subject: WIP: MSC_Tests: Add SGs testcases ...................................................................... Patch Set 17: (3 comments) > Patch Set 17: Code-Review+2 Note: We must not merge this before we have merged the related osmo-msc code. The reason for this is that the tests will try to access the SGs interface always on startup. So all tests will start to fail. https://gerrit.osmocom.org/#/c/11488/3/msc/MSC_Tests.default File msc/MSC_Tests.default: https://gerrit.osmocom.org/#/c/11488/3/msc/MSC_Tests.default@25 PS3, Line 25: > why did you remove the SGsAP. […] I probably dropped this unintentionally, however it works fine without. When I add the line again I get this warning: TC_sgsap_lu(23)@lobotron: Warning: Test port parameter sctp_stack is not supported on port SGsAP. https://gerrit.osmocom.org/#/c/11488/8/msc/MSC_Tests.ttcn File msc/MSC_Tests.ttcn: https://gerrit.osmocom.org/#/c/11488/8/msc/MSC_Tests.ttcn@3108 PS8, Line 3108: testcase TC_sgsap_lu_and_nothing() runs on MTC_CT { : var BSC_ConnHdlr vc_conn; : f_init(); : : vc_conn := f_start_handler(refers(f_tc_sgsap_lu_and_nothing), 3); : vc_conn.done; : } : : private function f_tc_sgsap_expl_imsi_det_eps(charstring id, BSC_ConnHdlrPars pars) : runs on BSC_ConnHdlr { : f_init_handler(pars); : f_sgs_perform_lu(); : f_sleep(3.0); : : var octetstring mme_name := f_enc_dns_hostname(mp_mme_name); : SGsAP.send(ts_SGsAP_EPS_DETACH_IND(g_pars.imsi, mme_name, UE_initiated)); : SGsAP.receive(tr_SGsAP_EPS_DETACH_ACK(g_pars.imsi)); : f_ctrl_get_exp(IPA_CTRL, "fsm.SGs-UE.id.imsi:" & hex2str(g_pars.imsi) & ".state", "SGs-NULL"); : > Same here, what is the purpose of that?!? o_O As long as this is work in progress you can ignore such quirks. I will remove this when everything is ready. https://gerrit.osmocom.org/#/c/11488/8/msc/MSC_Tests.ttcn@3186 PS8, Line 3186: : /* Wait for the states inside the MSC to settle and check the state : * of the SGs Association */ : > Here too... If both parts of this file are tooo unrelated, […] Done -- To view, visit https://gerrit.osmocom.org/11488 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I38543c35a9e74cea276e58d1d7ef01ef07ffe858 Gerrit-Change-Number: 11488 Gerrit-PatchSet: 17 Gerrit-Owner: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Vadim Yanitskiy <axilira...@gmail.com> Gerrit-CC: dexter <pma...@sysmocom.de> Gerrit-Comment-Date: Tue, 18 Dec 2018 16:30:38 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
