Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12268 )
Change subject: add to osmo_sock_get_name*() API ...................................................................... Patch Set 2: (1 comment) https://gerrit.osmocom.org/#/c/12268/2/src/socket.c File src/socket.c: https://gerrit.osmocom.org/#/c/12268/2/src/socket.c@825 PS2, Line 825: /* "r=1.2.3.4:123<->l=5.6.7.8:987" */ Could we keep this comment in osmo_sock_get_name() also? Without that command the 1 + 5 + 3 + 2 is impossible to understand. -- To view, visit https://gerrit.osmocom.org/12268 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8ad89ac447c9c582742e70d082072bdd40a5a398 Gerrit-Change-Number: 12268 Gerrit-PatchSet: 2 Gerrit-Owner: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-Reviewer: Pau Espin Pedrol <pes...@sysmocom.de> Gerrit-CC: Stefan Sperling <s...@stsp.name> Gerrit-Comment-Date: Tue, 18 Dec 2018 17:41:28 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No