Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12298 )
Change subject: MSC: adjust gsup log level to error ...................................................................... Patch Set 1: Code-Review+1 > Patch Set 1: > > I am not sure if this is a very good idea. Shouldn't the integration tests > log as much as possible to allow investigation afterwards. What if there is a > bug hiding in the gsub code? > > Maybe we should try to find a more reasonable logging level for the related > GSUP logging in osmo-msc? I agree that the message is annoying, I also see it a lot: Tue Dec 18 18:45:47 2018 DLGSUP <001b> gsup_client.c:73 GSUP connecting to 127.0.0.1:4222 Tue Dec 18 18:45:47 2018 DLGSUP <001b> gsup_client.c:131 GSUP link to 127.0.0.1:4222 DOWN Tue Dec 18 18:45:48 2018 DLGSUP <001b> gsup_client.c:73 GSUP connecting to 127.0.0.1:4222 Tue Dec 18 18:45:48 2018 DLGSUP <001b> gsup_client.c:131 GSUP link to 127.0.0.1:4222 DOWN Tue Dec 18 18:45:49 2018 DLGSUP <001b> gsup_client.c:73 GSUP connecting to 127.0.0.1:4222 Tue Dec 18 18:45:49 2018 DLGSUP <001b> gsup_client.c:131 GSUP link to 127.0.0.1:4222 DOWN Tue Dec 18 18:45:50 2018 DLGSUP <001b> gsup_client.c:73 GSUP connecting to 127.0.0.1:4222 Tue Dec 18 18:45:50 2018 DLGSUP <001b> gsup_client.c:131 GSUP link to 127.0.0.1:4222 DOWN Tue Dec 18 18:45:51 2018 DLGSUP <001b> gsup_client.c:73 GSUP connecting to 127.0.0.1:4222 Tue Dec 18 18:45:51 2018 DLGSUP <001b> gsup_client.c:131 GSUP link to 127.0.0.1:4222 DOWN Tue Dec 18 18:45:52 2018 DLGSUP <001b> gsup_client.c:73 GSUP connecting to 127.0.0.1:4222 Tue Dec 18 18:45:52 2018 DLGSUP <001b> gsup_client.c:131 GSUP link to 127.0.0.1:4222 DOWN Tue Dec 18 18:45:53 2018 DLGSUP <001b> gsup_client.c:73 GSUP connecting to 127.0.0.1:4222 Tue Dec 18 18:45:53 2018 DLGSUP <001b> gsup_client.c:131 GSUP link to 127.0.0.1:4222 DOWN Tue Dec 18 18:45:54 2018 DLGSUP <001b> gsup_client.c:73 GSUP connecting to 127.0.0.1:4222 Tue Dec 18 18:45:54 2018 DLGSUP <001b> gsup_client.c:131 GSUP link to 127.0.0.1:4222 DOWN Simply changing the log level of this message in osmo-msc might be fine indeed. -- To view, visit https://gerrit.osmocom.org/12298 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If79db99ceb7a9d4e2ec8d8b375aa628c4088c65c Gerrit-Change-Number: 12298 Gerrit-PatchSet: 1 Gerrit-Owner: Max <msur...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <msur...@sysmocom.de> Gerrit-Reviewer: Stefan Sperling <s...@stsp.name> Gerrit-Reviewer: daniel <dwillm...@sysmocom.de> Gerrit-Reviewer: dexter <pma...@sysmocom.de> Gerrit-Comment-Date: Tue, 18 Dec 2018 17:46:34 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes
