Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12350 )
Change subject: host/layer23: don't init SAP interface by default ...................................................................... Patch Set 1: > Patch Set 1: > > > There is code which calls sap_open() in mobile/app_mobile.c as > > well, and it's inside #if 0 ; should that dead code also be > > removed? > > WOW, yes, definitely! But, in a separate change ;) Sure, a separate patch is appropriate. -- To view, visit https://gerrit.osmocom.org/12350 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I62cc69c06fa15468a55bb0a9d408267d0745174c Gerrit-Change-Number: 12350 Gerrit-PatchSet: 1 Gerrit-Owner: Vadim Yanitskiy <axilira...@gmail.com> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Pau Espin Pedrol <pes...@sysmocom.de> Gerrit-Reviewer: Stefan Sperling <s...@stsp.name> Gerrit-Reviewer: Vadim Yanitskiy <axilira...@gmail.com> Gerrit-Comment-Date: Tue, 18 Dec 2018 17:49:54 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No
