dexter has posted comments on this change. ( https://gerrit.osmocom.org/12343 )
Change subject: msc_vty: also show IMEI and IMEISV ...................................................................... Patch Set 2: (2 comments) > Build Started https://jenkins.osmocom.org/jenkins/job/gerrit-osmo-msc/1076/ https://gerrit.osmocom.org/#/c/12343/2/src/libmsc/msc_vty.c File src/libmsc/msc_vty.c: https://gerrit.osmocom.org/#/c/12343/2/src/libmsc/msc_vty.c@642 PS2, Line 642: if (strlen(vsub->imei)) > Not critical but better for performance reasons, and it only requires one > line change, so I think it […] Done https://gerrit.osmocom.org/#/c/12343/2/src/libmsc/msc_vty.c@642 PS2, Line 642: if (strlen(vsub->imei)) > Yeah that would be a better idiom but not critical from my point of view. Done -- To view, visit https://gerrit.osmocom.org/12343 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iedd75dbb9850388ec1fedb984ed0b8bf4c62e780 Gerrit-Change-Number: 12343 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-Reviewer: Stefan Sperling <[email protected]> Gerrit-Reviewer: dexter <[email protected]> Gerrit-Comment-Date: Wed, 19 Dec 2018 09:19:30 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
