Vadim Yanitskiy has posted comments on this change. ( 
https://gerrit.osmocom.org/12373 )

Change subject: TLV: add convenience function for 1-byte values
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

https://gerrit.osmocom.org/#/c/12373/2/include/osmocom/gsm/tlv.h
File include/osmocom/gsm/tlv.h:

https://gerrit.osmocom.org/#/c/12373/2/include/osmocom/gsm/tlv.h@498
PS2, Line 498: Obtain 1-byte TLV element
Neels recently asked me to take care about punctuation, so let's please use 
dots.



--
To view, visit https://gerrit.osmocom.org/12373
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic0a148bd04b8860e321f509fdcd913f688c8e920
Gerrit-Change-Number: 12373
Gerrit-PatchSet: 2
Gerrit-Owner: Max <[email protected]>
Gerrit-Reviewer: Harald Welte <[email protected]>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Max <[email protected]>
Gerrit-Reviewer: Neels Hofmeyr <[email protected]>
Gerrit-Reviewer: Vadim Yanitskiy <[email protected]>
Gerrit-Comment-Date: Wed, 19 Dec 2018 20:56:07 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes

Reply via email to