Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/12384 )
Change subject: add API doc for LOGPFSM* macros ...................................................................... Patch Set 1: Code-Review+1 (3 comments) This is exactly what I was thinking about while reading previous change - comments! Looks fine, my comments are not critical. https://gerrit.osmocom.org/#/c/12384/1/include/osmocom/core/fsm.h File include/osmocom/core/fsm.h: https://gerrit.osmocom.org/#/c/12384/1/include/osmocom/core/fsm.h@123 PS1, Line 123: osmo_fsm_inst \ref https://gerrit.osmocom.org/#/c/12384/1/include/osmocom/core/fsm.h@125 PS1, Line 125: string format "format string" is more common term I think https://gerrit.osmocom.org/#/c/12384/1/include/osmocom/core/fsm.h@126 PS1, Line 126: String format same -- To view, visit https://gerrit.osmocom.org/12384 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3bf6500889aa58195f50a726dec0876c0c2baec3 Gerrit-Change-Number: 12384 Gerrit-PatchSet: 1 Gerrit-Owner: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Vadim Yanitskiy <[email protected]> Gerrit-Comment-Date: Thu, 20 Dec 2018 00:20:45 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
