Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12271 )
Change subject: tests/gsm0808: use new msgb comparison API ...................................................................... Patch Set 3: Code-Review-1 (1 comment) https://gerrit.osmocom.org/#/c/12271/3/tests/gsm0808/gsm0808_test.c File tests/gsm0808/gsm0808_test.c: https://gerrit.osmocom.org/#/c/12271/3/tests/gsm0808/gsm0808_test.c@45 PS3, Line 45: To avoid unintended side-effects from indentation without braces, this macro should be wrapped in do { ... } while (0); like EXPECTED_ENCODED above. Or just make this a proper function... -- To view, visit https://gerrit.osmocom.org/12271 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib6be778236eff8f2153f3113f9379ecfbec9052b Gerrit-Change-Number: 12271 Gerrit-PatchSet: 3 Gerrit-Owner: Max <msur...@sysmocom.de> Gerrit-Assignee: fixeria <axilira...@gmail.com> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <msur...@sysmocom.de> Gerrit-Reviewer: Pau Espin Pedrol <pes...@sysmocom.de> Gerrit-Reviewer: Stefan Sperling <s...@stsp.name> Gerrit-Reviewer: Vadim Yanitskiy <axilira...@gmail.com> Gerrit-CC: fixeria <axilira...@gmail.com> Gerrit-Comment-Date: Thu, 20 Dec 2018 11:08:41 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
