Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/12367 )
Change subject: LCLS: use proper types for value_string wrappers ...................................................................... Patch Set 2: When changing APIs, please provide information on when where they added and if a release was already done with previous version of the API. Also, did you make sure all users of this API in all osmocom repositories build fine with this file applied to libosmocore? I can image the compiler warning/erroring because you pass a uint8_t to an enum param. -- To view, visit https://gerrit.osmocom.org/12367 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0f47a610e06ac99bd60a5aad6f50f3658480165e Gerrit-Change-Number: 12367 Gerrit-PatchSet: 2 Gerrit-Owner: Max <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <[email protected]> Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-Comment-Date: Thu, 20 Dec 2018 11:16:48 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No
