Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/11919 )
Change subject: libmsc/gsm_04_11.c: forward MO SMS messages over GSUP ...................................................................... Patch Set 8: (1 comment) https://gerrit.osmocom.org/#/c/11919/2/src/libmsc/gsm_04_11.c File src/libmsc/gsm_04_11.c: https://gerrit.osmocom.org/#/c/11919/2/src/libmsc/gsm_04_11.c@674 PS2, Line 674: > Yep, I expected this question. The main idea is that some […] I agree that if { } else { } would be better. We shouldn't let code quality suffer just because code we write is supposed to be temporary. -- To view, visit https://gerrit.osmocom.org/11919 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7d651fde3d608d02f275a74043dc42262aabb1b8 Gerrit-Change-Number: 11919 Gerrit-PatchSet: 8 Gerrit-Owner: Vadim Yanitskiy <axilira...@gmail.com> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Vadim Yanitskiy <axilira...@gmail.com> Gerrit-CC: Harald Welte <lafo...@gnumonks.org> Gerrit-CC: Stefan Sperling <s...@stsp.name> Gerrit-Comment-Date: Thu, 20 Dec 2018 11:28:44 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
