Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/12388 )
Change subject: make sure early lchan act failure resets the lchan ...................................................................... Patch Set 1: (3 comments) https://gerrit.osmocom.org/#/c/12388/1/include/osmocom/bsc/gsm_data.h File include/osmocom/bsc/gsm_data.h: https://gerrit.osmocom.org/#/c/12388/1/include/osmocom/bsc/gsm_data.h@516 PS1, Line 516: struct gsm_lchan *re_use_mgw_endpoint_from_lchan; While at it, it would be great if you could please document better some of these fields. This one for instance I didn't exactly understand. From field name it actually looks like it should be a bool ;) Feel free to provide descriptions or renames in follow-up changes if you prefer. https://gerrit.osmocom.org/#/c/12388/1/src/osmo-bsc/lchan_fsm.c File src/osmo-bsc/lchan_fsm.c: https://gerrit.osmocom.org/#/c/12388/1/src/osmo-bsc/lchan_fsm.c@536 PS1, Line 536: /* From lchan_reset(): Where is lchan_reset() called? please provide that info in this line. (I know it's a cpy-paste from previous position, maybe a follow-up patch?). https://gerrit.osmocom.org/#/c/12388/1/src/osmo-bsc/lchan_fsm.c@569 PS1, Line 569: use_mgwep_ci = lchan_use_mgw_endpoint_ci_bts(lchan); where does this line come from? I don't see it in the previous block (previous commit file state <-). -- To view, visit https://gerrit.osmocom.org/12388 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ide665b10fa3f4583059c55346db8da833959e3cc Gerrit-Change-Number: 12388 Gerrit-PatchSet: 1 Gerrit-Owner: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-CC: Pau Espin Pedrol <[email protected]> Gerrit-Comment-Date: Thu, 20 Dec 2018 11:52:11 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
