Max has posted comments on this change. ( https://gerrit.osmocom.org/12364 )
Change subject: fix ipa_asp_fsm down state transition ...................................................................... Patch Set 1: (2 comments) https://gerrit.osmocom.org/#/c/12364/1/src/xua_asp_fsm.c File src/xua_asp_fsm.c: https://gerrit.osmocom.org/#/c/12364/1/src/xua_asp_fsm.c@939 PS1, Line 939: osmo_timer_del(&iafp->pong_timer); > This timer is actually never scheduled as far as I can see. […] Sure, simple /* FIXME: ... */ will do as well. https://gerrit.osmocom.org/#/c/12364/1/src/xua_asp_fsm.c@1060 PS1, Line 1060: ipa_asp_fsm_del_route(fi); > In an earlier version of this patch I just called ipa_asp_fsm_cleanup() from > ipa_asp_fsm_active(). […] Ah, now I see. Than your variant with separate function and wrapper is better indeed. I still would prefer not to pass fi to ipa_asp_fsm_del_route() to make the distinction between fsm-specific part and generic cleanup more obvious. -- To view, visit https://gerrit.osmocom.org/12364 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idb8e7bd1c74a4b47080fe32ebe0161c503ead571 Gerrit-Change-Number: 12364 Gerrit-PatchSet: 1 Gerrit-Owner: Stefan Sperling <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <[email protected]> Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Stefan Sperling <[email protected]> Gerrit-Comment-Date: Thu, 20 Dec 2018 12:01:54 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
