Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12243 )
Change subject: make gsup ipa name configurable in osmo-sgsn.cfg ...................................................................... Patch Set 6: (2 comments) https://gerrit.osmocom.org/#/c/12243/5/src/gprs/sgsn_vty.c File src/gprs/sgsn_vty.c: https://gerrit.osmocom.org/#/c/12243/5/src/gprs/sgsn_vty.c@181 PS5, Line 181: ipa-name > Missing "gsup" prefix. […] Ooops, thanks nice catch. https://gerrit.osmocom.org/#/c/12243/5/src/gprs/sgsn_vty.c@1092 PS5, Line 1092: "It can only be se > Could we just warn user that this change has no effect until restart? […] Please read the long discussion above before adding further input to this topic. -- To view, visit https://gerrit.osmocom.org/12243 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib2f65fed9f56b9718e8a9647e3f01dce69870c1f Gerrit-Change-Number: 12243 Gerrit-PatchSet: 6 Gerrit-Owner: Stefan Sperling <s...@stsp.name> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <msur...@sysmocom.de> Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-Reviewer: Pau Espin Pedrol <pes...@sysmocom.de> Gerrit-Reviewer: Stefan Sperling <s...@stsp.name> Gerrit-Reviewer: Vadim Yanitskiy <axilira...@gmail.com> Gerrit-CC: osmith <osm...@sysmocom.de> Gerrit-Comment-Date: Thu, 20 Dec 2018 15:11:52 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No