Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/12316 )
Change subject: ctrl: separate config structure ...................................................................... Patch Set 2: (1 comment) https://gerrit.osmocom.org/#/c/12316/2/src/osysmon_ctrl.c File src/osysmon_ctrl.c: https://gerrit.osmocom.org/#/c/12316/2/src/osysmon_ctrl.c@41 PS2, Line 41: struct ctrl_cfg *cfg; Do we really need a pointer allocated by talloc here? and an alloc function? just to have 2 strings and one int, all this seems overengineered to me. What's the benefit from previous code? Just move the struct to the shared header, that's all needed right? -- To view, visit https://gerrit.osmocom.org/12316 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sysmon Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3520e14ca6e1b8e270dbd4b1bf2378fe486991ce Gerrit-Change-Number: 12316 Gerrit-PatchSet: 2 Gerrit-Owner: Max <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <[email protected]> Gerrit-CC: Pau Espin Pedrol <[email protected]> Gerrit-CC: Stefan Sperling <[email protected]> Gerrit-Comment-Date: Thu, 20 Dec 2018 15:48:15 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
