Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/12383 )
Change subject: define LOGPFSM fmt only once, in LOGPFSMLSRC ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/12383/1/include/osmocom/core/fsm.h File include/osmocom/core/fsm.h: https://gerrit.osmocom.org/#/c/12383/1/include/osmocom/core/fsm.h@122 PS1, Line 122: LOGPFSML > Maybe rather place it between LOGPFSMLSRC and LOGPFSM? […] i chose this order: most-explicit first, most-implicit last, and each one followed by its *SRC version. Whichever way you choose, something will look out of order. -- To view, visit https://gerrit.osmocom.org/12383 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2f23c57ebfdb5355919c06ac5ded7732e3b17a97 Gerrit-Change-Number: 12383 Gerrit-PatchSet: 1 Gerrit-Owner: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Vadim Yanitskiy <[email protected]> Gerrit-Comment-Date: Thu, 20 Dec 2018 22:31:23 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
