Neels Hofmeyr has uploaded this change for review. (
https://gerrit.osmocom.org/12406
Change subject: comments: describe some lchan details
......................................................................
comments: describe some lchan details
(requested by pespin)
Change-Id: I04ec4ce1fd2b7b110bb496186aae39ecfbbc3628
---
M include/osmocom/bsc/gsm_data.h
M src/osmo-bsc/lchan_fsm.c
2 files changed, 4 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/06/12406/1
diff --git a/include/osmocom/bsc/gsm_data.h b/include/osmocom/bsc/gsm_data.h
index 2090142..9f7ce8d 100644
--- a/include/osmocom/bsc/gsm_data.h
+++ b/include/osmocom/bsc/gsm_data.h
@@ -509,10 +509,13 @@
/* This always is for a specific lchan, so its lchan->type indicates
full or half rate.
* When a dyn TS was selected, the lchan->type has been set to the
desired rate. */
enum gsm48_chan_mode chan_mode;
+ /* AMR config */
uint16_t s15_s0;
bool requires_voice_stream;
bool wait_before_switching_rtp; /*< true = requires
LCHAN_EV_READY_TO_SWITCH_RTP */
uint16_t msc_assigned_cic;
+ /* During intra-BSC handover, we keep the MGW endpoint intact and just
re-route to the new lchan. This
+ * activate_info is for the new lchan, the
re_use_mgw_endpoint_from_lchan points at the old lchan. */
struct gsm_lchan *re_use_mgw_endpoint_from_lchan;
};
diff --git a/src/osmo-bsc/lchan_fsm.c b/src/osmo-bsc/lchan_fsm.c
index fc1bcbf..f344cf9 100644
--- a/src/osmo-bsc/lchan_fsm.c
+++ b/src/osmo-bsc/lchan_fsm.c
@@ -533,7 +533,7 @@
lchan->rqd_ta = old_lchan->rqd_ta;
} else {
lchan->ms_power = ms_pwr_ctl_lvl(bts->band, bts->ms_max_power);
- /* From lchan_reset():
+ /* Upon last entering the UNUSED state, from lchan_reset():
* - bs_power is still zero, 0dB reduction, output power = Pn.
* - TA is still zero, to be determined by RACH. */
}
--
To view, visit https://gerrit.osmocom.org/12406
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I04ec4ce1fd2b7b110bb496186aae39ecfbbc3628
Gerrit-Change-Number: 12406
Gerrit-PatchSet: 1
Gerrit-Owner: Neels Hofmeyr <[email protected]>
