Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/12380 )
Change subject: add a test for LU with invalid LAI ...................................................................... Patch Set 2: Code-Review-1 (2 comments) https://gerrit.osmocom.org/#/c/12380/1/msc/MSC_Tests.ttcn File msc/MSC_Tests.ttcn: https://gerrit.osmocom.org/#/c/12380/1/msc/MSC_Tests.ttcn@2844 PS1, Line 2844: tr_ML3_MT_LU_Rej > I don't know which cause would be appropriate per the spec. […] I think it's fine to receive a reject and not care about the cause; the causes are under-specified, or we haven't found the sweet spec that explains all the right reject causes yet. Any cause is good enough until we encounter a particular problem with it, I guess. https://gerrit.osmocom.org/#/c/12380/2/msc/MSC_Tests.ttcn File msc/MSC_Tests.ttcn: https://gerrit.osmocom.org/#/c/12380/2/msc/MSC_Tests.ttcn@2851 PS2, Line 2851: } f_expect_clear() like in that other patch I just +2'ed? -- To view, visit https://gerrit.osmocom.org/12380 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I676894358259b9cc0f973769ce552ba58a2a58a1 Gerrit-Change-Number: 12380 Gerrit-PatchSet: 2 Gerrit-Owner: Stefan Sperling <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Stefan Sperling <[email protected]> Gerrit-CC: Vadim Yanitskiy <[email protected]> Gerrit-Comment-Date: Fri, 21 Dec 2018 02:24:24 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
