Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/12411 )
Change subject: Reply to CHECK-IMEI GSUP messages ...................................................................... Patch Set 2: (1 comment) https://gerrit.osmocom.org/#/c/12411/2/src/hlr.c File src/hlr.c: https://gerrit.osmocom.org/#/c/12411/2/src/hlr.c@431 PS2, Line 431: osmo_gsup_encode Not critical, but what if this function would fail? I think we should check the return value. -- To view, visit https://gerrit.osmocom.org/12411 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib240474b0c3c603ba840cf26babb38a44dfc9364 Gerrit-Change-Number: 12411 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: osmith <[email protected]> Gerrit-CC: Vadim Yanitskiy <[email protected]> Gerrit-Comment-Date: Fri, 21 Dec 2018 18:54:03 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
