Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/12377 )
Change subject: LCLS: don't send invalid status in HO messages ...................................................................... Patch Set 5: > > provide information on when was this API added > > Which API are you talking about? And how the time of addition is > relevent to whether we should use it or not? lcls_bss_status_present is a field in a public structure, so it's part of the public API right? Time of addition matters. If it was already present in an older release, then we should avoid changing it to prevent from API breakage. If it was included after latest release, it's fine to change it since it was never released. -- To view, visit https://gerrit.osmocom.org/12377 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2dc3a2896b133298cbf850d68e6898300884bbce Gerrit-Change-Number: 12377 Gerrit-PatchSet: 5 Gerrit-Owner: Max <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <[email protected]> Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-Reviewer: Stefan Sperling <[email protected]> Gerrit-Comment-Date: Sat, 29 Dec 2018 17:59:13 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No
