Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/5629 )
Change subject: BSSGP: use monotonic clock ...................................................................... Patch Set 2: Code-Review-1 (3 comments) https://gerrit.osmocom.org/#/c/5629/2/include/osmocom/gprs/gprs_bssgp.h File include/osmocom/gprs/gprs_bssgp.h: https://gerrit.osmocom.org/#/c/5629/2/include/osmocom/gprs/gprs_bssgp.h@69 PS2, Line 69: struct timeval time_last_pdu; /*!< deprecated! will be replaced by t_last_pdu eventually */ Same as prev commit, eventually? it's actually being removed now. https://gerrit.osmocom.org/#/c/5629/2/src/gb/gprs_bssgp.c File src/gb/gprs_bssgp.c: https://gerrit.osmocom.org/#/c/5629/2/src/gb/gprs_bssgp.c@619 PS2, Line 619: if (clock_gettime(CLOCK_MONOTONIC, &fc->t_last_pdu) != 0) osmo_clock_gettime. https://gerrit.osmocom.org/#/c/5629/2/tests/gb/bssgp_fc_test.c File tests/gb/bssgp_fc_test.c: https://gerrit.osmocom.org/#/c/5629/2/tests/gb/bssgp_fc_test.c@104 PS2, Line 104: fc->t_last_pdu.tv_nsec += OSMO_USEC2NS(100000); better use timeradd from osmocom/core/timer_compat.h -- To view, visit https://gerrit.osmocom.org/5629 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If190a634aa8334cae55df8c41877400d2f5603a2 Gerrit-Change-Number: 5629 Gerrit-PatchSet: 2 Gerrit-Owner: Max <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <[email protected]> Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-Comment-Date: Sun, 30 Dec 2018 23:40:31 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
