Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/12459 )
Change subject: add SIP P-Access-Network-Info in MO/invites: RAT types ...................................................................... Patch Set 2: Code-Review-1 The commitlog should state *why* something is done, not just what it is done. That's the single most frequent problem I see in commit logs of any software project. So please explain why this information is added, what kind of specifications relate to it, how it is used, ... -- To view, visit https://gerrit.osmocom.org/12459 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sip-connector Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I186c315d22816b2552b16ec0788718e05de28c3d Gerrit-Change-Number: 12459 Gerrit-PatchSet: 2 Gerrit-Owner: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Comment-Date: Thu, 03 Jan 2019 10:27:48 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes
